Release 3.2.0-beta.2 #184
Merged
Release 3.2.0-beta.2 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Nov 15, 2024
oschwald
commented
- Set release date
- Update config file for phpstan 2
- Improve type hints for PHPStan
- Use typed properties
- Fix questionable handling of falsey values
- Remove redundant is_string check
- Remove checks that are no longer needed
- Update dependencies
For better handling of null values.
horgh
requested changes
Nov 15, 2024
src/MinFraud/ServiceClient.php
Outdated
| @@ -62,6 +67,10 @@ protected function maybeThrowInvalidInputException(string $msg): void | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @param array<string, mixed> $array | |||
| * @param list<string> $types | |||
| @@ -19,8 +19,7 @@ | |||
| "require": { | |||
| "php": ">=8.1", | |||
| "ext-json": "*", | |||
| "geoip2/geoip2": "^v3.0.0", | |||
| "maxmind/web-service-common": "^0.9.0" | |||
There was a problem hiding this comment.
We don't need an explicit dep on this now?
There was a problem hiding this comment.
We get it from geiop2/geoip2. I think I added it as an explicit dep when I wanted to force newer version when geoip2/geoip2 had not been updated yet. It seems slightly easier to manage as an implicit dep, but I can see arguments both ways.
horgh
previously approved these changes
Nov 15, 2024
horgh
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.